Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check output of fread/fwrite in compression #237

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Check output of fread/fwrite in compression #237

merged 1 commit into from
Dec 16, 2019

Conversation

zmichaels11
Copy link
Contributor

Changes

  • Check return type of fread and log to error
  • Check return type of fwrite and log to error

Issues

Signed-off-by: Zachary Michaels zmichaels11@gmail.com

@zmichaels11
Check output of fread/fwrite in compression
5f6275e 
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@dirk-thomas dirk-thomas mentioned this pull request Dec 16, 2019
Merged
piraka9011
piraka9011 approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@piraka9011 piraka9011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Though we should probably move this error checking (for both r/w) to a separate utility function.

@zmichaels11 zmichaels11 merged commit f32ba2a into ros2:master Dec 16, 2019
@zmichaels11 zmichaels11 deleted the zmichaels11/resolve-warning branch December 16, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piraka9011 piraka9011 piraka9011 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ROS 2 Tooling Working Milestone #2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zmichaels11 @piraka9011 @thomas-moulard