Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compression] Use vector resize instead of reserve #243

Merged
merged 3 commits into from
Jan 3, 2020
Merged

[Compression] Use vector resize instead of reserve #243

merged 3 commits into from
Jan 3, 2020

Conversation

zmichaels11
Copy link
Contributor

Changes:

  • Use std::vector::resize instead of std::vector::reserve

Issues:

@zmichaels11 zmichaels11 force-pushed the compression/zstdcompressor-vector-resize branch from c9a9555 to 4a462d7 Compare January 2, 2020 23:22
@zmichaels11 zmichaels11 marked this pull request as ready for review January 2, 2020 23:47
@zmichaels11 zmichaels11 requested a review from mm318 January 2, 2020 23:58
@zmichaels11
Copy link
Contributor Author

@ros2/aws-oncall - please run this CI job
Gist: https://gist.githubusercontent.com/zmichaels11/475e351af3a308ff5c3ed2eea2b19e54/raw/29deb7ad85747ebbb7796087a6754d361bd3f9c0/ros2.repos
BUILD args: --packages-up-to rosbag2_compression
TEST args: --packages-select rosbag2_compression
Job: ci_launcher

@dabonnie
Copy link
Contributor

dabonnie commented Jan 3, 2020

@ros2/aws-oncall - please run this CI job
Gist: https://gist.githubusercontent.com/zmichaels11/475e351af3a308ff5c3ed2eea2b19e54/raw/29deb7ad85747ebbb7796087a6754d361bd3f9c0/ros2.repos
BUILD args: --packages-up-to rosbag2_compression
TEST args: --packages-select rosbag2_compression
Job: ci_launcher

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@zmichaels11 zmichaels11 mentioned this pull request Jan 3, 2020
Closed
piraka9011
piraka9011 approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@piraka9011 piraka9011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the aforementioned discussion, this LGTM.

@zmichaels11
Use vector resize instead of reserve
23f3d36 
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11
Use fill constructor on std::vector
e3a27d6 
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11
Remove empty line
bcaa099 
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11 zmichaels11 force-pushed the compression/zstdcompressor-vector-resize branch from 729b157 to bcaa099 Compare January 3, 2020 17:27
@zmichaels11
Copy link
Contributor Author

zmichaels11 commented Jan 3, 2020 •
edited
Loading

I'll merge this once all checks complete.

Edit:

  • Windows: Build Status

@zmichaels11 zmichaels11 merged commit 226971e into ros2:master Jan 3, 2020
@zmichaels11 zmichaels11 deleted the compression/zstdcompressor-vector-resize branch January 3, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karsten1987 Karsten1987 Karsten1987 approved these changes

@mm318 mm318 mm318 approved these changes

@piraka9011 piraka9011 piraka9011 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zmichaels11 @dabonnie @Karsten1987 @mm318 @piraka9011