-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Compression] Use vector resize instead of reserve #243
[Compression] Use vector resize instead of reserve #243
Conversation
c9a9555
to
4a462d7
Compare
rosbag2_compression/src/rosbag2_compression/zstd_compressor.cpp
Outdated
Show resolved
Hide resolved
rosbag2_compression/src/rosbag2_compression/zstd_compressor.cpp
Outdated
Show resolved
Hide resolved
@ros2/aws-oncall - please run this CI job |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the aforementioned discussion, this LGTM.
rosbag2_compression/src/rosbag2_compression/zstd_compressor.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
729b157
to
bcaa099
Compare
Changes:
std::vector::resize
instead ofstd::vector::reserve
Issues: