[compression] Move compression artifacts from rosbag2_cpp to rosbag2_compression #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
piraka9011
requested review from
zmichaels11,
dabonnie,
Karsten1987 and
prajakta-gokhale
and removed request for
zmichaels11
zmichaels11
approved these changes
Jan 15, 2020
rosbag2_compression/test/rosbag2_compression/test_compression_options.cpp
Show resolved
Hide resolved
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
|
dabonnie
approved these changes
Jan 16, 2020
prajakta-gokhale
approved these changes
Jan 16, 2020
This was referenced Jan 16, 2020
zmichaels11
changed the title
2 tasks
MichaelOrlov
added a commit
that referenced
this pull request
Sep 1, 2022
compression_options.cpp was supposed to be moved to the `rosbag2_compression` package in #257 but was forgotten to delete from `rosbag2_cpp` package. Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
added a commit
that referenced
this pull request
Sep 14, 2022
compression_options.cpp was supposed to be moved to the `rosbag2_compression` package in #257 but was forgotten to delete from `rosbag2_cpp` package. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
emersonknapp
pushed a commit
that referenced
this pull request
Mar 11, 2023
compression_options.cpp was supposed to be moved to the `rosbag2_compression` package in #257 but was forgotten to delete from `rosbag2_cpp` package. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit 50e28cb) Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dependency of both
zstdandrosbag2_compressionfromrosbag2_cpp.This is part of a multi-PR effort to:
rosbag2_compression.rosbag2_compression.rosbag2_transportbased on the CLI.ros2bag.Signed-off-by: Anas Abou Allaban allabana@amazon.com