Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compression] Add SequentialCompressionWriter #260

Merged
merged 4 commits into from
Jan 22, 2020
Merged

[compression] Add SequentialCompressionWriter #260

merged 4 commits into from
Jan 22, 2020

Conversation

zmichaels11
Copy link
Contributor

@zmichaels11 zmichaels11 commented Jan 17, 2020 •
edited
Loading

Add a SequentialCompressionWriter that uses ZStandard compression to write bagfiles.
Depends on PR: #258

@zmichaels11
Add a SequentialCompressionWriter
fa99bec 
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
@zmichaels11 zmichaels11 changed the title Add SequentialCompressionWriter [compression] Add SequentialCompressionWriter Jan 21, 2020
@zmichaels11
Apply similar suggestions from SequentialReader
506dc78 
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11 zmichaels11 marked this pull request as ready for review January 21, 2020 21:26
piraka9011
piraka9011 approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@piraka9011 piraka9011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Karsten1987
Karsten1987 reviewed Jan 21, 2020
View reviewed changes
Copy link
Collaborator

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's the same comment I made for the reader implementation of this, but there's quite some code duplication around which I believe should be addressed by inheritance.

Otherwise, I guess that looks good so far if all tests pass.

rosbag2_compression/include/rosbag2_compression/sequential_compression_writer.hpp Show resolved Hide resolved
rosbag2_compression/include/rosbag2_compression/sequential_compression_writer.hpp Show resolved Hide resolved
rosbag2_compression/src/rosbag2_compression/sequential_compression_writer.cpp Show resolved Hide resolved
@zmichaels11
Sort headers
16ad8cb 
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11
Copy link
Contributor Author

@ros2/aws-oncall - please run this CI job
Gist: https://gist.githubusercontent.com/zmichaels11/9efc41e881105216c991c462df6cb861/raw/a93bccdef38118d8dd19d1c41f300a6e1ba7bea6/ros2.repos
BUILD args: --packages-up-to rosbag2_compression
TEST args: --packages-select rosbag2_compression
Job: ci_launcher

@piraka9011
Copy link
Contributor

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@zmichaels11
Disable warning 4251 on windows
a69795c 
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11
Copy link
Contributor Author

Run again with change for Windows:

  • Windows Build Status

@zmichaels11 zmichaels11 merged commit c34601a into ros2:master Jan 22, 2020
@zmichaels11 zmichaels11 deleted the sc-writer branch January 22, 2020 00:36
@zmichaels11 zmichaels11 mentioned this pull request Jan 22, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karsten1987 Karsten1987 Karsten1987 left review comments

@piraka9011 piraka9011 piraka9011 approved these changes

@thomas-moulard thomas-moulard Awaiting requested review from thomas-moulard

@dabonnie dabonnie Awaiting requested review from dabonnie

@emersonknapp emersonknapp Awaiting requested review from emersonknapp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zmichaels11 @piraka9011 @Karsten1987