Change validation functions to accept output type of ZSTD_getFrameContentSize #285
Conversation
…tentSize Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
|
please run this CI job |
|
The lint warning is from using Edit: /**
* Checks compression_result and throws a runtime_error if there was a ZSTD error.
* \param compression_result is the return value of ZSTD_decompress.
*/
void throw_on_zstd_error(
const decltype(ZSTD_decompress(nullptr, 0, nullptr, 0)) compression_result
)Be acceptable? |
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
|
I think you missed a hallway discussion with Thomas; paraphrasing: |
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
zmichaels11
deleted the
zmichaels11/compression/fix-implicit-conversion
branch
| @@ -34,6 +34,8 @@ constexpr const int kDefaultZstdCompressionLevel = 1; | |||
|
|
|||
| // String constant used to identify ZstdCompressor. | |||
| constexpr const char kCompressionIdentifier[] = "zstd"; | |||
| // Used as a parameter type in a function that accepts the output of ZSTD_compress. | |||
| using ZstdCompressReturnType = decltype(ZSTD_compress(nullptr, 0, nullptr, 0, 0)); | |||
There was a problem hiding this comment.
Maybe use https://en.cppreference.com/w/cpp/types/result_of instead of making a function call.
There was a problem hiding this comment.
decltype actually doesn't make a function call! (I'll update with the document stating this)
There was a problem hiding this comment.
Never mind. decltype doesn't invoke anything, but result_of is better in this situation because you won't need to write the dummy values to "pass" into the ZSTD_compress() function.
There was a problem hiding this comment.
Yeah, I agree, unfortunately I merged this before you commented.
Addresses the same issue to #282.
The root cause of the problem was an implicit conversion from
unsigned long longtosize_t(same on x86_64 platforms)Changes
unsigned long longdirectly. This is the return type of ZSTD_getFrameContentSizeSigned-off-by: Zachary Michaels zmichaels11@gmail.com