Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include stdexcept #314

Merged
merged 2 commits into from
Mar 7, 2020
Merged

Include stdexcept #314

merged 2 commits into from
Mar 7, 2020

Conversation

zmichaels11
Copy link
Contributor

@zmichaels11 zmichaels11 commented Mar 7, 2020 •
edited by piraka9011
Loading

Intended to fix windows build introduced in #311 (comment)

Fixes #312

Signed-off-by: Zachary Michaels zmichaels11@gmail.com

@zmichaels11
Include stdexcept
4f30350 
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11
Copy link
Contributor Author

@ros2/aws-oncall @prajakta-gokhale @thomas-moulard - please run this CI job
Gist: https://gist.githubusercontent.com/zmichaels11/6561bdd7b4a7415df6db8f79f9b7457a/raw/bcde204ca0b811fda4abc0dbcba273d492ba616f/ros2.repos
BUILD args: --packages-up-to rosbag2_compression
TEST args: --packages-select rosbag2_compression
Job: ci_launcher

@zmichaels11
Copy link
Contributor Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@zmichaels11 zmichaels11 mentioned this pull request Mar 7, 2020
Merged
@zmichaels11
Copy link
Contributor Author

Windows build is unstable due to a compiler warning.
Fix is to disable, see:

rosbag2/rosbag2_storage/include/rosbag2_storage/storage_factory.hpp

Line 27 in 4f30350

// This is necessary because of using stl types here. It is completely safe, because

@zmichaels11
disable warning 4251 on win32
ba78cb0 
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11
Copy link
Contributor Author

  • Windows Build Status

Karsten1987
Karsten1987 approved these changes Mar 7, 2020
View reviewed changes
Copy link
Collaborator

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm if ci comes back green

@zmichaels11 zmichaels11 mentioned this pull request Mar 7, 2020
Merged
@zmichaels11 zmichaels11 merged commit 45a088d into ros2:master Mar 7, 2020
@zmichaels11 zmichaels11 deleted the zmichaels11/fix-compression-factory-impl branch March 7, 2020 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karsten1987 Karsten1987 Karsten1987 approved these changes

@piraka9011 piraka9011 piraka9011 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build error on Windows related to rosbag2_compression
3 participants
@zmichaels11 @Karsten1987 @piraka9011