Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed rosidl_generator_cpp in rosbag2_transport because it's not been used #321

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Removed rosidl_generator_cpp in rosbag2_transport because it's not been used #321

merged 1 commit into from
Mar 19, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Mar 13, 2020

rosbag2_transport package is using rosidl_generator_cpp but this dependency is not been find_package in the CMakeLists.txt or included in the package.xml. Headers are not been used here neither . I think we should remove it

Signed-off-by: ahcorde ahcorde@gmail.com

@ahcorde ahcorde added the enhancement New feature or request label Mar 13, 2020
@ahcorde ahcorde self-assigned this Mar 13, 2020
@ahcorde ahcorde mentioned this pull request Mar 13, 2020
Merged
emersonknapp
emersonknapp approved these changes Mar 13, 2020
View reviewed changes
Copy link
Collaborator

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ahcorde
Copy link
Contributor Author

ahcorde commented Mar 13, 2020

Should I run the CI?

Karsten1987
Karsten1987 approved these changes Mar 18, 2020
View reviewed changes
Copy link
Collaborator

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@ahcorde please go ahead and trigger a CI. I think build up to rosbag2 and test all packages above rosbag2_transport should be totally sufficient.

@ahcorde
Copy link
Contributor Author

ahcorde commented Mar 18, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Mar 19, 2020

I built up to ros2bag not rosbag2 Running again

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Mar 19, 2020

there is failed test in Windows:

can we merge it?

@Karsten1987
Copy link
Collaborator

@ahcorde feel free to merge.

@ahcorde ahcorde merged commit 1fd35b5 into master Mar 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/rosbag2_transport/removed_rosidl_generator_cpp branch March 19, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@Karsten1987 Karsten1987 Karsten1987 approved these changes

Assignees

@ahcorde ahcorde

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @Karsten1987 @emersonknapp