Add project() to sqlite3_cmakelists.txt

[brawner]

Attempting to address issue #323. I'm not sure if this is the correct way of going about this since it's being included from another cmakelists.txt. I'm also open to naming the project whatever you all think is appropriate. I just didn't want to name it sqlite3_vendor (already taken) nor sqlite3 (may conflict with another cmake project?).

Signed-off-by: Stephen Brawner brawner@gmail.com

[brawner]

• Linux
• Linux-aarch64
• macOS
• Windows

[Karsten1987]

You repos file is incorrect I believe:

  ros2/rosbag2:
    type: git
    url: git@github.com:brawner/rosbag2
    version: sqlite3_cmakelists

the url should be provided in form of https://github.com/...

[Karsten1987]

I actually think naming it sqlite3 is okay as it should not conflict with any CMake context in this case.

[brawner]

Arg, thought I could be clever and just use vcs export

• Linux
• Linux-aarch64
• macOS
• Windows

[Karsten1987]

looks like the osrf testing tools are giving the windows CI a hard time. Maybe you can retrigger CI and explicitly skip that package? Should be unrelated to this change here anyway.

[Karsten1987]

I can't quite see it, but what's the diff here?

[brawner]

A newline was added at the end of the file (my editor does this automatically). Let me know if this needs to be changed back

[Karsten1987]

it's all good. I was just wondering as GitHub doesn't really seem to render this change.

[brawner]

Looks like Dirk got the fix in for osrf_testing_tools. Trying again

Windows

[Karsten1987]

Does it make sense to run the windows CI job without cyclone and connext? I think these CI failures are addressed more appropriately at another place and shouldn't really block to move this PR further.

[brawner]

We've temporarily set buildtools back to 16.4.5. Trying on windows again.

[brawner]

Building on windows finally passed. Failing test is a known issue (#305)