Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use interface_include_directories #426

Merged
merged 1 commit into from
Jun 10, 2020
Merged

use interface_include_directories #426

merged 1 commit into from
Jun 10, 2020

Conversation

Karsten1987
Copy link
Collaborator

fixes #422

Signed-off-by: Karsten Knese <karsten@openrobotics.org>
@Karsten1987
Copy link
Collaborator Author

build up to rosbag2, test sqlite3_vendor

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Karsten1987
Copy link
Collaborator Author

@jacobperron I can see how we want to table this for past-foxy, but I couldn't find a project board for a foxy patch release yet. Is there already something like that?

@jacobperron jacobperron added this to In progress in Foxy Patch Release 1 via automation Jun 2, 2020
Foxy Patch Release 1 automation moved this from In progress to Reviewer approved Jun 2, 2020
@jacobperron jacobperron moved this from Reviewer approved to In progress in Foxy Patch Release 1 Jun 5, 2020
@jacobperron
Copy link
Member

@Karsten1987 Is this ready to go?

@Karsten1987 Karsten1987 merged commit 895242a into master Jun 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the rosbag2_422 branch June 10, 2020 18:20
@jacobperron jacobperron moved this from In progress to Needs backport in Foxy Patch Release 1 Jun 10, 2020
Karsten1987 added a commit that referenced this pull request Jun 17, 2020
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Karsten1987 added a commit that referenced this pull request Jun 18, 2020
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
@Karsten1987 Karsten1987 moved this from Needs backport to Needs release in Foxy Patch Release 1 Jun 23, 2020
@jacobperron jacobperron removed this from Needs release in Foxy Patch Release 1 Jun 24, 2020
adamdbrw pushed a commit to RobotecAI/rosbag2 that referenced this pull request Aug 4, 2020
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FindSQLite3.cmake - target property for include folder
2 participants