add sqlite3 vendor package for cross-platform capabilities #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agalbachicar
added a commit
to agalbachicar/rosbag2
that referenced
this pull request
Dec 7, 2021
* Adds the PlayFor.srv description. * Implements the play_for verb. * Allows the Subscription manager to spin based on a duration. * Adds to the CMakeLists.txt the message description. * Adds a basic test. * Switch to C++ 17 * Adds * for explicit optional deferentiation. * Adds test with playback for a certain duration. Duration is less than the further message in the queue. * Adds tests with filtered topics. * Improves testing code by removing duplicated code. * Adds PlayUntil service message. * Changes the implementation to support time until. * Adds the service. * Adds test coverage to Player::play_until(timestamp). - Allows to edit BagMetadata from MockReaderInterface. - Provides unit tests to play with different timing initial conditions. - Provides unit tests to play with filtered topics. - Alphasorts the tests for the CMakeList.txt. * Adds python bindings for play until verb * Update ros2bag/ros2bag_backport/verb/play.py Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> * Update rosbag2_transport/src/rosbag2_transport/player.cpp Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> * Update rosbag2_transport/test/rosbag2_transport/test_play_until.cpp Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> * Update rosbag2_transport/test/rosbag2_transport/test_play_until.cpp Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
MichaelOrlov
pushed a commit
that referenced
this pull request
Mar 31, 2024
…r_review_1 Fixes for services playback per review 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.