Only dereference the data pointer if it is valid. #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the static_cast returned a nullptr, then just print the message and don't attempt to deference it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
requested review from
emersonknapp and
dabonnie
and removed request for
a team
|
CI:
|
|
It looks like test_message_cache is flakey on macOS, so we can ignore that failure. |
emersonknapp
approved these changes
Dec 7, 2020
delete-merged-branch
bot
deleted the
clalancette/fix-test-nullptr-access
branch
emersonknapp
pushed a commit
that referenced
this pull request
Feb 2, 2021
If the static_cast returned a nullptr, then just print the message and don't attempt to deference it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
emersonknapp
pushed a commit
that referenced
this pull request
Feb 17, 2021
If the static_cast returned a nullptr, then just print the message and don't attempt to deference it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the static_cast returned a nullptr, then just print the
message and don't attempt to deference it.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org