Remove rosbag2_compression test dependencies on zstd implementation in prep for moving it into a separate package #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n prep for moving it into a separate package Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
requested review from
thomas-moulard and
zmichaels11
and removed request for
a team
|
Gist: https://gist.githubusercontent.com/emersonknapp/c4b653f6a59d718ab5c23156164d7f23/raw/d68e33d8a45aa81fac2bcede277215f47741542d/ros2.repos
|
zmichaels11
approved these changes
Feb 4, 2021
rosbag2_compression/test/rosbag2_compression/test_sequential_compression_reader.cpp
Outdated
Show resolved
Hide resolved
added 2 commits
February 4, 2021 16:29
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
…the DLL linkage information around the fake plugin, which is not intended to be linked against Signed-off-by: Emerson Knapp <eknapp@amazon.com>
|
delete-merged-branch
bot
deleted the
emersonknapp/compression-tests-no-require-zstd
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #598
Make the
rosbag2_compressiontests use a generic test plugin instead of a specific real implementation. Remove the tests that are simply testing that the mock does some arbitrary behavior - now that these mocks are actually being used by a real test.Once zstd implementation moves to separate
rosbag2_compression_zstdpackage - we cannot depend on using that implementation in this interface package, the dependency relationship will go the opposite direction