remodel publication manager #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Karsten1987
requested review from
emersonknapp and
zmichaels11
and removed request for
a team
|
CI without
I don't necessarily expect a clean CI here, but the record end to end tests should pass. |
|
master is currently broken due to ros2/rmw_cyclonedds#306 |
|
building without CycloneDDS:
|
emersonknapp
approved these changes
Apr 22, 2021
| rclcpp::get_logger("publication_manager"), | ||
| "publish on topic %s", publisher->get_topic_name()); | ||
| } | ||
| std::this_thread::sleep_for(interval); |
There was a problem hiding this comment.
Would there be a slightly simpler way to build this with timers instead? Not sure, just thinking out loud
There was a problem hiding this comment.
I am actually in favor of this solution. Timers involve node spinning and executors. Here I can simply call publish and sleep.
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
|
with cyclone
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things here:
publisher_managertopublication_manager.rclcpp::initwasn't triggered just yet.record_end_to_end_tests