-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remodel publication manager #749
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
103 changes: 103 additions & 0 deletions
103
rosbag2_test_common/include/rosbag2_test_common/publication_manager.hpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,103 @@ | ||
// Copyright 2018, Bosch Software Innovations GmbH. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
#ifndef ROSBAG2_TEST_COMMON__PUBLICATION_MANAGER_HPP_ | ||
#define ROSBAG2_TEST_COMMON__PUBLICATION_MANAGER_HPP_ | ||
|
||
#include <functional> | ||
#include <future> | ||
#include <memory> | ||
#include <string> | ||
#include <vector> | ||
|
||
#include "rclcpp/rclcpp.hpp" // rclcpp must be included before the Windows specific includes. | ||
|
||
using namespace std::chrono_literals; // NOLINT | ||
|
||
namespace rosbag2_test_common | ||
{ | ||
|
||
class PublicationManager | ||
{ | ||
public: | ||
PublicationManager() | ||
: pub_node_(std::make_shared<rclcpp::Node>( | ||
"publication_manager_" + std::to_string(rclcpp::Clock().now().nanoseconds()), | ||
rclcpp::NodeOptions().start_parameter_event_publisher(false).enable_rosout(false))) | ||
{} | ||
|
||
template<class MsgT> | ||
void setup_publisher( | ||
const std::string & topic_name, | ||
const std::shared_ptr<MsgT> message, | ||
const size_t repetition, | ||
const rclcpp::QoS & qos = rclcpp::QoS{rclcpp::KeepAll()}, | ||
const std::chrono::milliseconds interval = 50ms) | ||
{ | ||
return setup_publisher(topic_name, *message, repetition, qos, interval); | ||
} | ||
|
||
template<class MsgT> | ||
void setup_publisher( | ||
const std::string & topic_name, | ||
const MsgT & message, | ||
const size_t repetition, | ||
const rclcpp::QoS & qos = rclcpp::QoS{rclcpp::KeepAll()}, | ||
const std::chrono::milliseconds interval = 50ms) | ||
{ | ||
auto publisher = pub_node_->create_publisher<MsgT>(topic_name, qos); | ||
|
||
publishers_.push_back( | ||
[publisher, message, repetition, interval](bool verbose = false) { | ||
for (auto i = 0u; i < repetition; ++i) { | ||
if (rclcpp::ok()) { | ||
publisher->publish(message); | ||
if (verbose) { | ||
RCLCPP_INFO( | ||
rclcpp::get_logger("publication_manager"), | ||
"publish on topic %s", publisher->get_topic_name()); | ||
} | ||
std::this_thread::sleep_for(interval); | ||
} | ||
} | ||
}); | ||
} | ||
|
||
void run_publishers(bool verbose = false) const | ||
{ | ||
for (const auto & pub_fcn : publishers_) { | ||
pub_fcn(verbose); | ||
} | ||
} | ||
|
||
void run_publishers_async(bool verbose = false) const | ||
{ | ||
std::vector<std::future<void>> futures; | ||
for (const auto & pub_fcn : publishers_) { | ||
futures.push_back(std::async(std::launch::async, pub_fcn, verbose)); | ||
} | ||
for (auto & publisher_future : futures) { | ||
publisher_future.get(); | ||
} | ||
} | ||
|
||
private: | ||
std::shared_ptr<rclcpp::Node> pub_node_; | ||
using PublicationF = std::function<void (bool)>; | ||
std::vector<PublicationF> publishers_; | ||
}; | ||
|
||
} // namespace rosbag2_test_common | ||
|
||
#endif // ROSBAG2_TEST_COMMON__PUBLICATION_MANAGER_HPP_ |
129 changes: 0 additions & 129 deletions
129
rosbag2_test_common/include/rosbag2_test_common/publisher_manager.hpp
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would there be a slightly simpler way to build this with timers instead? Not sure, just thinking out loud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am actually in favor of this solution. Timers involve node spinning and executors. Here I can simply call publish and sleep.