Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add callbacks for PlayerClock::jump(time_point) API (#775)" #778

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Revert "Add callbacks for PlayerClock::jump(time_point) API (#775)" #778

merged 1 commit into from
Jun 11, 2021

Conversation

emersonknapp
Copy link
Collaborator

@emersonknapp emersonknapp commented Jun 11, 2021 •
edited
Loading

This reverts commit abd4229 for #775

Windows build started failing, since CI wasn't run for this PR before merging

@emersonknapp
Revert "Add callbacks for PlayerClock::jump(time_point) API (#775)"
b219fb4 
This reverts commit abd4229.

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp emersonknapp requested a review from a team as a code owner June 11, 2021 19:21
@emersonknapp emersonknapp requested review from jaisontj and prajakta-gokhale and removed request for a team June 11, 2021 19:21
@emersonknapp emersonknapp mentioned this pull request Jun 11, 2021
Merged
@emersonknapp
Copy link
Collaborator Author

Gist: https://gist.githubusercontent.com/emersonknapp/ef088041e86de551f5439fee3bcc47f5/raw/289e108895384a6a31ae47b75d07011c2277c9af/ros2.repos
BUILD args: --packages-up-to rosbag2_cpp rosbag2_tests
TEST args: --packages-select rosbag2_cpp rosbag2_tests
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/8562

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

clalancette
clalancette approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good assuming CI goes green.

Thanks!

@emersonknapp emersonknapp merged commit 758d96b into master Jun 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the emersonknapp/revert-775 branch June 11, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@jaisontj jaisontj Awaiting requested review from jaisontj

@prajakta-gokhale prajakta-gokhale Awaiting requested review from prajakta-gokhale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emersonknapp @clalancette