Updated benchmark package to use writer close() instead of old reset() #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
adamdbrw
requested review from
lihui815,
zmichaels11 and
emersonknapp
and removed request for
a team
|
I see some test failures that are clearly unrelated |
|
This also needs a Galactic backport since the issue is there as well |
emersonknapp
approved these changes
Oct 13, 2021
emersonknapp
pushed a commit
that referenced
this pull request
Oct 15, 2021
) * Updated benchmark package to use writer close() instead of old reset() Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * Updated node declare_parameter to new syntax - also added required defaults for optional parameters (qos set) Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor fix which restores benchmarking package build.
rosbag2_performance_benchmarkingstopped building since #760. The reason for this going under the radar might be that CI checks no longer build this package with required flagBUILD_ROSBAG2_BENCHMARKS. We need to address that by either removing the flag and making package build by default, or making sure the flag stays in auto checks.