Auto-detect storage_id for Reader (if possible) #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom metadata Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
force-pushed
the
emersonknapp/detect-storage-for-play
branch
from
57595e9
to
b831425
Compare
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
force-pushed
the
emersonknapp/detect-storage-for-play
branch
from
2833253
to
cedf12c
Compare
emersonknapp
requested review from
gbiggs and
lihui815
and removed request for
a team
|
Gist: https://gist.githubusercontent.com/emersonknapp/c47c754008db2b39a5030b111ed67492/raw/7d33210aab5d74fdd9bbf7d2ff7e84c013176f7a/ros2.repos
|
emersonknapp
changed the title
delete-merged-branch
bot
deleted the
emersonknapp/detect-storage-for-play
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #831
Most bags have a metadata file associated with them. If that's the case, then it's not strictly necessary to specify the storage format when playing back a bag, it can be determined. This is a quality of life improvement for non-default storage implementations (and for bag conversion input bags, in progress feature)