You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #831
Going to use this filter for Converter functionality to choose which Writers receive which topics from Readers. The single-call structure makes it clear that both the Recorder and the Converter use the same logic.
The current implementation was hard to understand the order of operations for the topic filter.
This new implementation fully checks each topic all the way through all filters, allowing it to be easily used for a single topic, or iterate over a container. This is a mild optimization in that only a single container copy is done, rather than repeatedly copying into a new container for each filter step.
More importantly, it makes the pipeline of functions easier to follow and extend by clearly showing the linear order of filters for a topic.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emersonknapp
requested review from
gbiggs and
lihui815
and removed request for
a team
delete-merged-branch
bot
deleted the
emersonknapp/topic-filter-single-call
branch
Part of #831
Going to use this filter for Converter functionality to choose which Writers receive which topics from Readers. The single-call structure makes it clear that both the Recorder and the Converter use the same logic.
The current implementation was hard to understand the order of operations for the topic filter.
This new implementation fully checks each topic all the way through all filters, allowing it to be easily used for a single topic, or iterate over a container. This is a mild optimization in that only a single container copy is done, rather than repeatedly copying into a new container for each filter step.
More importantly, it makes the pipeline of functions easier to follow and extend by clearly showing the linear order of filters for a topic.