Improve test_time_controller test

[Blast545]

Should close #992

It's a simple fix for a test that was heavily relying on the the OS not waking up as explained here:
#992 (comment)

This test right before it makes the same assumption:

rosbag2/rosbag2_cpp/test/rosbag2_cpp/test_time_controller_clock.cpp

Line 150 in 5fa3a67

EXPECT_TRUE(clock.sleep_until(clock.now() + 100));

But as it haven't failed I decided not to change it with this PR.

Signed-off-by: Jorge Perez jjperez@ekumenlabs.com

[MichaelOrlov]

@Blast545 Thank you for the PR.
CI build fails due to forgotten

#include <rclcpp/utilities.hpp>

Please add it.

[Blast545]

Checks are passing, running full CI:

• Linux
• Linux-aarch64 -> Known to be failing infra issue.
• Windows

[MichaelOrlov]

Approve!

[emersonknapp]

I know this is over a year old, but I'm adding some context here for future historians: This PR didn't actually do anything to the test - since rclcpp is not used in the test, the loop never ran, which means that any spurious wakeup still caused the test to fail. The original 100 nanosecond sleep request test likely never failed because it was very unlikely or maybe even impossible for a spurious wakeup to happen in that time frame. The new loop added in this test, on the other hand, slept for a full second (10 million times longer), which made a spurious wakeup far more likely (which is not handled because the loop is never entered), and therefore actually made this test far more likely to fail, which is why we've seen it so flaky.