Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Humble] make recorder node composable by inheritance (backport #1093) #1097

Merged

Conversation

bertaveira
Copy link
Contributor

Same as #1093 and #892 but for branch Humble

Signed-off-by: Bernardo Taveira taveira@student.chalmers.se

Signed-off-by: Bernardo Taveira <taveira@student.chalmers.se>
@bertaveira bertaveira requested a review from a team as a code owner September 21, 2022 11:08
@bertaveira bertaveira requested review from emersonknapp and hidmic and removed request for a team September 21, 2022 11:08
@MichaelOrlov MichaelOrlov changed the title Enable composable Recorder node in Humble [Humble] make recorder node composable by inheritance Sep 21, 2022
@MichaelOrlov
Copy link
Contributor

Gist: https://gist.githubusercontent.com/MichaelOrlov/07ddd3fc7f0c79f374a181a2761f19b1/raw/7f649de35f70abc6d8794dd53c440d65d6d24866/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_transport rosbag2_tests
TEST args: --packages-above rosbag2_transport rosbag2_tests
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/10859

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov MichaelOrlov changed the title [Humble] make recorder node composable by inheritance [Humble] make recorder node composable by inheritance (backport #1093) Sep 21, 2022
@MichaelOrlov MichaelOrlov merged commit 4018e5e into ros2:humble Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants