New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parametrize all rosbag2_tests for both supported storage plugins #1221
Changes from 6 commits
8454eea
d0c0474
75b65af
7d4dd1f
b9f8e02
aa83e8d
770ac09
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,7 +42,8 @@ if(BUILD_TESTING) | |
|
||
ament_add_gmock(test_rosbag2_record_end_to_end | ||
test/rosbag2_tests/test_rosbag2_record_end_to_end.cpp | ||
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}) | ||
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} | ||
TIMEOUT 120) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note: new test suite just takes longer than the default minute, given the doubled number of tests There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like this timeout needs to be increased further for this test to pass. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was wrong - there was a broken test which caused this suite to time out. I've pushed a commit to fix it. |
||
if(TARGET test_rosbag2_record_end_to_end) | ||
ament_target_dependencies(test_rosbag2_record_end_to_end | ||
rclcpp | ||
|
@@ -96,7 +97,8 @@ if(BUILD_TESTING) | |
rosbag2_cpp | ||
rosbag2_storage | ||
rosbag2_storage_default_plugins | ||
rosbag2_test_common) | ||
rosbag2_test_common | ||
std_msgs) | ||
endif() | ||
|
||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
rosbag2_bagfile_information: | ||
version: 6 | ||
storage_identifier: mcap | ||
duration: | ||
nanoseconds: 151137181 | ||
starting_time: | ||
nanoseconds_since_epoch: 1586406456763032325 | ||
message_count: 7 | ||
topics_with_message_count: | ||
- topic_metadata: | ||
name: /array_topic | ||
type: test_msgs/msg/Arrays | ||
serialization_format: cdr | ||
offered_qos_profiles: "- history: 3\n depth: 0\n reliability: 1\n durability: 2\n deadline:\n sec: 0\n nsec: 0\n lifespan:\n sec: 0\n nsec: 0\n liveliness: 1\n liveliness_lease_duration:\n sec: 0\n nsec: 0\n avoid_ros_namespace_conventions: false" | ||
message_count: 4 | ||
- topic_metadata: | ||
name: /test_topic | ||
type: test_msgs/msg/BasicTypes | ||
serialization_format: cdr | ||
offered_qos_profiles: "- history: 3\n depth: 0\n reliability: 1\n durability: 2\n deadline:\n sec: 0\n nsec: 0\n lifespan:\n sec: 0\n nsec: 0\n liveliness: 1\n liveliness_lease_duration:\n sec: 0\n nsec: 0\n avoid_ros_namespace_conventions: false" | ||
message_count: 3 | ||
compression_format: "" | ||
compression_mode: "" | ||
relative_file_paths: | ||
- cdr_test_0.mcap | ||
files: | ||
- path: cdr_test_0.mcap | ||
starting_time: | ||
nanoseconds_since_epoch: 1586406456763032325 | ||
duration: | ||
nanoseconds: 151137181 | ||
message_count: 7 | ||
custom_data: ~ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
rosbag2_bagfile_information: | ||
version: 6 | ||
storage_identifier: mcap | ||
duration: | ||
nanoseconds: 151137181 | ||
starting_time: | ||
nanoseconds_since_epoch: 1586406456763032325 | ||
message_count: 7 | ||
topics_with_message_count: | ||
- topic_metadata: | ||
name: /array_topic | ||
type: test_msgs/msg/Arrays | ||
serialization_format: wrong_format | ||
offered_qos_profiles: "- history: 3\n depth: 0\n reliability: 1\n durability: 2\n deadline:\n sec: 0\n nsec: 0\n lifespan:\n sec: 0\n nsec: 0\n liveliness: 1\n liveliness_lease_duration:\n sec: 0\n nsec: 0\n avoid_ros_namespace_conventions: false" | ||
message_count: 4 | ||
- topic_metadata: | ||
name: /test_topic | ||
type: test_msgs/msg/BasicTypes | ||
serialization_format: wrong_format | ||
offered_qos_profiles: "- history: 3\n depth: 0\n reliability: 1\n durability: 2\n deadline:\n sec: 0\n nsec: 0\n lifespan:\n sec: 0\n nsec: 0\n liveliness: 1\n liveliness_lease_duration:\n sec: 0\n nsec: 0\n avoid_ros_namespace_conventions: false" | ||
message_count: 3 | ||
compression_format: "" | ||
compression_mode: "" | ||
relative_file_paths: | ||
- wrong_rmw_test_0.mcap | ||
files: | ||
- path: wrong_rmw_test_0.mcap | ||
starting_time: | ||
nanoseconds_since_epoch: 1586406456763032325 | ||
duration: | ||
nanoseconds: 151137181 | ||
message_count: 7 | ||
custom_data: ~ |
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: before this was leaving the storage ID blank in a reindex operation, if storage id not specified by user.