Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction based sqlite3 inserts #225

Merged
merged 25 commits into from Apr 1, 2020
Merged

Transaction based sqlite3 inserts #225

merged 25 commits into from Apr 1, 2020

Commits on Apr 1, 2020

  1. First iteration of batched/transation based inserts. 

    * We control the transaction using APIs activate_transacation and
  commit_trasaction.
* The no_of_inserts, is a crude hack to enbale periodic commits to the
  database file.
* We are doing inserts, one after the other. So, we'd have to control
  transactions this way.
* The ideal way is to have a lower-task take care of writing to db,
  which creates bulk inserts from a datastructure
* Problems, powerfailure handling!

Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>
    @Karsten1987
    Sriram Raghunathan authored and Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    ef0a73f View commit details
    Browse the repository at this point in the history

  2. Commit trasactions on intermediate failures 

    Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>
    @Karsten1987
    Sriram Raghunathan authored and Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    4dc0a57 View commit details
    Browse the repository at this point in the history

  3. Changes made to fit coding style and first level of review comments 

    Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>
    @Karsten1987
    Sriram Raghunathan authored and Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    a254e19 View commit details
    Browse the repository at this point in the history

  4. Fix compilation issue and uncrustify errors 

    Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>
    @Karsten1987
    Sriram Raghunathan authored and Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    67bcdcd View commit details
    Browse the repository at this point in the history

  5. First iteration of batched/transation based inserts. 

    * We control the transaction using APIs activate_transacation and
  commit_trasaction.
* The no_of_inserts, is a crude hack to enbale periodic commits to the
  database file.
* We are doing inserts, one after the other. So, we'd have to control
  transactions this way.
* The ideal way is to have a lower-task take care of writing to db,
  which creates bulk inserts from a datastructure
* Problems, powerfailure handling!

Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>
    @Karsten1987
    Sriram Raghunathan authored and Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    1d6b4cf View commit details
    Browse the repository at this point in the history

  6. Commit trasactions on intermediate failures 

    Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>
    @Karsten1987
    Sriram Raghunathan authored and Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    6fef091 View commit details
    Browse the repository at this point in the history

  7. Changes made to fit coding style and first level of review comments 

    Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>
    @Karsten1987
    Sriram Raghunathan authored and Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    8898cd4 View commit details
    Browse the repository at this point in the history

  8. Fix compilation issue and uncrustify errors 

    Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>
    @Karsten1987
    Sriram Raghunathan authored and Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    37c0e40 View commit details
    Browse the repository at this point in the history

  9. Rework transaction to fit in the comments from pull request, 

    The idea here is to move the transaction control to a higher layer
i.e rosbag2_cpp from that of lower level fine control.

This gives the flexibilty of independent plugin and caching
implementation wihtin the application

Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>
    @Karsten1987
    Sriram Raghunathan authored and Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    fe65e3e View commit details
    Browse the repository at this point in the history

  10. Fix errors creeped in due to rebase. Compilation fails due to 

    rosbag2_compression.

Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>
    @Karsten1987
    Sriram Raghunathan authored and Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    2a5f601 View commit details
    Browse the repository at this point in the history

  11. Fix compilation issue and uncrustify errors 

    Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>
    @Karsten1987
    Sriram Raghunathan authored and Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    c1bd37d View commit details
    Browse the repository at this point in the history

  12. Fix errors creeped in due to rebase. Compilation fails due to 

    rosbag2_compression.

Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>
    @Karsten1987
    Sriram Raghunathan authored and Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    b3d2b3e View commit details
    Browse the repository at this point in the history

  13. Fix, uncrustify issues and address comments from github issue 225 

    Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>
    @Karsten1987
    Sriram Raghunathan authored and Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    342a4c7 View commit details
    Browse the repository at this point in the history

  14. review comments 

    Signed-off-by: Karsten Knese <karsten@openrobotics.org>
    @Karsten1987
    Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    a7effdc View commit details
    Browse the repository at this point in the history

  15. reset cache 

    Signed-off-by: Karsten Knese <karsten@openrobotics.org>
    @Karsten1987
    Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    c0768c9 View commit details
    Browse the repository at this point in the history

  16. disable cache when set to lt 1 

    Signed-off-by: Karsten Knese <karsten@openrobotics.org>
    @Karsten1987
    Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    bc60c79 View commit details
    Browse the repository at this point in the history

  17. test cache behavior in sequential writer 

    Signed-off-by: Karsten Knese <karsten@openrobotics.org>
    @Karsten1987
    Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    1ebc289 View commit details
    Browse the repository at this point in the history

  18. uncrustify 

    Signed-off-by: Karsten Knese <karsten@openrobotics.org>
    @Karsten1987
    Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    381a103 View commit details
    Browse the repository at this point in the history

  19. fix cpplint 

    Signed-off-by: Karsten Knese <karsten@openrobotics.org>
    @Karsten1987
    Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    23804e8 View commit details
    Browse the repository at this point in the history

  20. address review comments 

    Signed-off-by: Karsten Knese <karsten@openrobotics.org>
    @Karsten1987
    Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    21b2c80 View commit details
    Browse the repository at this point in the history

  21. correct sqlite statements 

    Signed-off-by: Karsten Knese <karsten@openrobotics.org>
    @Karsten1987
    Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    83042cc View commit details
    Browse the repository at this point in the history

  22. expose max cache size through transport 

    Signed-off-by: Karsten Knese <karsten@openrobotics.org>
    @Karsten1987
    Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    bac3558 View commit details
    Browse the repository at this point in the history

  23. linters 

    Signed-off-by: Karsten Knese <karsten@openrobotics.org>
    @Karsten1987
    Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    3d2647a View commit details
    Browse the repository at this point in the history

  24. add end to end test for cache 

    Signed-off-by: Karsten Knese <karsten@openrobotics.org>
    @Karsten1987
    Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    d46f141 View commit details
    Browse the repository at this point in the history

  25. uint64_t 

    Signed-off-by: Karsten Knese <karsten@openrobotics.org>
    @Karsten1987
    Karsten1987 committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    b4401d6 View commit details
    Browse the repository at this point in the history