Use foxy testing apt repos to install linters for Actions #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersonknapp
force-pushed
the
emersonknapp/foxy-testing-linters
branch
2 times, most recently
from
e6f83a5
to
4785009
Compare
|
Would it make sense to use the linters from the master branch? I mean, the moment something changes upstream we'll have the same inconsistency as right now in which the binary packages are different from ci.ros2.org. Is that right? |
|
I think that it does make sense - but for the moment action-ros-lint operates by expecting to install the linters via Then, there is ros-tooling/action-ros-lint#142 which requests we install the linters via |
|
Can you rebase this on top of master? I'd expect the |
added 3 commits
July 17, 2020 16:39
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
force-pushed
the
emersonknapp/foxy-testing-linters
branch
from
4785009
to
1924ecd
Compare
Karsten1987
approved these changes
Jul 17, 2020
emersonknapp
added a commit
that referenced
this pull request
Feb 2, 2021
* Use foxy testing apt repos to install linters for Actions Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
added a commit
that referenced
this pull request
Feb 17, 2021
* Use foxy testing apt repos to install linters for Actions Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were still using the Eloquent release of the linters, which is not accurate to the current code.
Depends on #461
Signed-off-by: Emerson Knapp eknapp@amazon.com