[backport foxy] Deduplicate SequentialCompressionReader business logic, add fallback to find bagfiles in incorrectly-written metadata #612 #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to find bagfiles in incorrectly-written metadata (#612) * Deduplicate sequentialcompressionreader business logic, add fallback to find bagfiles in incorrectly-written metadata Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
changed the title
zmichaels11
approved these changes
Jan 27, 2021
|
Gist: https://gist.githubusercontent.com/emersonknapp/66f4e42a9c3bab6ddefde22785cc5d14/raw/cd58280a18a21ff42711609cd31444cd9fed26ab/ros2.repos
|
|
@ros-pull-request-builder retest this please |
|
Closing for now in favor of discussion on #625 - will reopen if we do not go that direction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #612 to Foxy
This PR allows rosbag2 to correctly read the incorrect V4 metadata files being currently written by compressed bags. It removes most of the business logic from the SequentialCompressionReader in preparation for removing the class entirely.