Renaming struct members for consistency #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and rosbag2_storage::TopicwithType to TopicMetadata - The former TopicWithTye struct will be enlarged to contain also the rmw serialization format relative to the topic. This is why the name 'TopicMetadata' is now better suited for it.
Karsten1987
approved these changes
Nov 26, 2018
sriramster
pushed a commit
to sriramster/rosbag2
that referenced
this pull request
Feb 28, 2019
* ros2GH-64 Rearrange default plugins build to use public headers Also already links write integration test against the default plugins. * ros2GH-64 Remove after_write_action Query the underlying db directly in tests to determine the amount of recorded messages. * ros2GH-64 Add convenience getter for single line SQL result * ros2GH-64 Add visibility macros to enable linking on Windows * ros2GH-64 Remove second sqlite exception class (it is not needed) * ros2GH-64 Fix hanging rosbag2_read_integration_test * ros2GH-64 Always log sqlite return code * ros2GH-64 Improve opening of sqlite database - Always open db with threading mode multi-thread. This forbids sharing database connections across threads. Db access from multiple threads is possible when each thread uses its own connection. - Open sqlite db accordingly to given io flags. Readonly open works only with already existing database. - Set journal mode pragma to WAL (write ahead log) and synchronous pragma to NORMAL. This should yield good write performance. - Small fix: use *.db3 as db name in tests. * ros2GH-64 Fix package test dependencies * ros2GH-64 Fix cppcheck error * ros2GH-64 Fix asserting typesupport in test (varies on architectures) * Cleanup - consistently use const ref of string instead of string for function arguments - simplify package dependencies - minor formatting * Make play integration test compile on Mac * Fix sqlite_wrapper_integration_test
james-rms
added a commit
to james-rms/rosbag2
that referenced
this pull request
Nov 17, 2022
Signed-off-by: James Smith <james@foxglove.dev> Signed-off-by: James Smith <james@foxglove.dev>
james-rms
added a commit
to james-rms/rosbag2
that referenced
this pull request
Nov 17, 2022
Signed-off-by: James Smith <james@foxglove.dev> Signed-off-by: James Smith <james@foxglove.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #57:
time_stamp