Don't preprocess a storage file more than once #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes problem on file decompression, which would try to decompress the already-decompressed file Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Sonia Jin <diegothemuich@gmail.com>
lihui815
requested review from
zmichaels11,
prajakta-gokhale and
emersonknapp
and removed request for
a team,
zmichaels11 and
prajakta-gokhale
emersonknapp
approved these changes
Oct 27, 2021
Signed-off-by: Sonia Jin <diegothemuich@gmail.com>
|
Gist: https://gist.githubusercontent.com/emersonknapp/1830772ca6864d8c07f8a14680a66720/raw/966d0b1434fe5dcdc83c8100bd0e935045e5af4b/ros2.repos
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes exception on file-compression playback, which would try to decompress the already-decompressed file. Keeps track of already preprocessed files, and only preprocess the new ones.
Added regression test that fails without the fix.
Took over from #889