Address peer review comments

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ros2 · May 14, 2020 · 7c1af45 · 7c1af45
1 parent ee57927
commit 7c1af45
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/...upport_introspection_c/cmake/rosidl_typesupport_introspection_c_generate_interfaces.cmake b/...upport_introspection_c/cmake/rosidl_typesupport_introspection_c_generate_interfaces.cmake
@@ -14,8 +14,8 @@
 
 if(NOT rosidl_generator_c_FOUND)
   message(FATAL_ERROR
-    "Executing rosidl_typesupport_introspection_c extension point when rosidl_generator_c wasn't found."
-    "Make sure rosidl_generator_c is installed.")
+    "'rosidl_generator_c' not found when executing "
+    "'rosidl_typesupport_introspection_c' extension.")
 endif()
 
 set(_output_path

diff --git a/rosidl_typesupport_introspection_c/rosidl_typesupport_introspection_c-extras.cmake.in b/rosidl_typesupport_introspection_c/rosidl_typesupport_introspection_c-extras.cmake.in
@@ -6,10 +6,10 @@
 set(rosidl_typesupport_introspection_c_LIBRARY_TYPE
   "@rosidl_typesupport_introspection_c_LIBRARY_TYPE@")
 
-find_package(ament_cmake_core QUIET REQUIRED)
 # Make sure rosidl_generator_c extension point is registered first
 find_package(rosidl_generator_c QUIET)
 
+find_package(ament_cmake_core QUIET REQUIRED)
 ament_register_extension(
   "rosidl_generate_idl_interfaces"
   "rosidl_typesupport_introspection_c"

diff --git a/...rt_introspection_cpp/cmake/rosidl_typesupport_introspection_cpp_generate_interfaces.cmake b/...rt_introspection_cpp/cmake/rosidl_typesupport_introspection_cpp_generate_interfaces.cmake
@@ -14,8 +14,8 @@
 
 if(NOT rosidl_generator_c_FOUND)
   message(FATAL_ERROR
-    "Executing rosidl_typesupport_introspection_cpp extension point when rosidl_generator_c wasn't found."
-    "Make sure rosidl_generator_cpp is installed.")
+    "'rosidl_generator_cpp' not found when executing "
+    "'rosidl_typesupport_introspection_cpp' extension.")
 endif()
 
 set(_output_path

diff --git a/rosidl_typesupport_introspection_cpp/rosidl_typesupport_introspection_cpp-extras.cmake.in b/rosidl_typesupport_introspection_cpp/rosidl_typesupport_introspection_cpp-extras.cmake.in
@@ -6,11 +6,10 @@
 set(rosidl_typesupport_introspection_cpp_LIBRARY_TYPE
   "@rosidl_typesupport_introspection_cpp_LIBRARY_TYPE@")
 
-find_package(ament_cmake_core QUIET REQUIRED)
-
 # Make sure extension points are registered in order
 find_package(rosidl_generator_cpp QUIET)
 
+find_package(ament_cmake_core QUIET REQUIRED)
 ament_register_extension(
   "rosidl_generate_idl_interfaces"
   "rosidl_typesupport_introspection_cpp"