Allow 'get_const_expr_value' to parse either literals or scoped_names… #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ros2#429) Signed-off-by: kyle.marcey <kyle.marcey@apex.ai>
kylemarcey
force-pushed
the
fix_idl_attribute_support
branch
from
7d8be18
to
8f4752f
Compare
|
Please also update the unit tests to cover the newly supported case. |
kylemarcey
added a commit
to kylemarcey/rosidl
that referenced
this pull request
Jan 10, 2020
Signed-off-by: kyle.marcey <kyle.marcey@apex.ai>
kylemarcey
force-pushed
the
fix_idl_attribute_support
branch
from
0119ba3
to
697f52c
Compare
ivanpauno
added
enhancement
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
… the comment and output the whole tree in case of unsupported case Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
|
Thanks for the patch. In the future please comment on the PR after pushing commits - otherwise nobody is being notified that the PR needs another look. I added a few commits:
I hope these changes make sense to you. CI build on Linux only: |
|
Yes, those changes make sense to me, thanks! |
|
Fast forwarded the change to the |
dirk-thomas
moved this from Needs Backport
to Needs Release
in Eloquent Patch Release 1
dirk-thomas
added a commit
that referenced
this pull request
Jan 16, 2020
#430) * Allow 'get_const_expr_value' to parse either literals or scoped_names (#429) Signed-off-by: kyle.marcey <kyle.marcey@apex.ai> * Add test case for annotation using scoped_name (#430) Signed-off-by: kyle.marcey <kyle.marcey@apex.ai> * fix linter warning Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * check len of children before accessing them Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * nitpick: swap comparison sides Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * avoid finding single literal again Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * since const_expr could contain different expressions (e.g. or) remove the comment and output the whole tree in case of unsupported case Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
added a commit
that referenced
this pull request
Jan 16, 2020
#430) (#431) * Allow 'get_const_expr_value' to parse either literals or scoped_names (#429) Signed-off-by: kyle.marcey <kyle.marcey@apex.ai> * Add test case for annotation using scoped_name (#430) Signed-off-by: kyle.marcey <kyle.marcey@apex.ai> * fix linter warning Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * check len of children before accessing them Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * nitpick: swap comparison sides Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * avoid finding single literal again Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * since const_expr could contain different expressions (e.g. or) remove the comment and output the whole tree in case of unsupported case Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Co-authored-by: kylemarcey <marcey.kyle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_const_expr_valueinparser.pyto work when the const expr is a scoped_name as well as when it is a literalFixes #429.