only export ament_cmake_core instead of ament_cmake #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
changed the title
cottsay
approved these changes
Apr 11, 2020
delete-merged-branch
bot
deleted the
dirk-thomas/export-only-ament_cmake_core
branch
This was referenced Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the API reviews #446 and #447.
Only
ament_cmake_coreis used downstream by the exported CMake logic:rosidl/rosidl_generator_c/cmake/register_c.cmake
Line 16 in 0b938b0
rosidl/rosidl_generator_cpp/cmake/register_cpp.cmake
Line 16 in 0b938b0