Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor regex for valid package/field names #508

Merged
merged 1 commit into from
Jul 23, 2020
Merged

refactor regex for valid package/field names #508

merged 1 commit into from
Jul 23, 2020

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented Jul 22, 2020 •
edited
Loading

Fixes a problem reported in colcon/colcon-core#364.

Without the patch the regex can take an huge amount of time for some invalid input, e.g.:

import re
x = re.compile('^[a-z]([a-z0-9_]?[a-z0-9]+)*$')
x.match('txt_msg_autoflow_added_to_current_ventilation_mode"')

CI builds testing rosidl_adapter and downstream packages (with only Fast DDS):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
    • (Unrelated test failure)

@dirk-thomas
refactor regex for valid package/field names
0cfa2e6 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas added the bug Something isn't working label Jul 22, 2020
@dirk-thomas dirk-thomas self-assigned this Jul 22, 2020
@dirk-thomas dirk-thomas added this to Proposed in Foxy Patch Release 2 via automation Jul 22, 2020
@dirk-thomas dirk-thomas added this to Needs release in Rolling Ridley Jul 22, 2020
@dirk-thomas dirk-thomas moved this from Proposed to Needs backport in Foxy Patch Release 2 Jul 22, 2020
@dirk-thomas dirk-thomas added this to Needs Backport in Dashing Patch Release 8 Jul 22, 2020
@dirk-thomas dirk-thomas added this to Needs Backport in Eloquent Patch Release 2 Jul 22, 2020
@dirk-thomas dirk-thomas mentioned this pull request Jul 22, 2020
Closed
jacobperron
jacobperron approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dirk-thomas dirk-thomas merged commit f66e937 into master Jul 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/refactor-regex branch July 23, 2020 06:14
@jacobperron jacobperron removed this from Needs backport in Foxy Patch Release 2 Aug 7, 2020
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 3 via automation Aug 7, 2020
@jacobperron jacobperron moved this from Proposed to Needs backport in Foxy Patch Release 3 Aug 7, 2020
@jacobperron jacobperron removed this from Needs backport in Foxy Patch Release 3 Oct 9, 2020
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 4 via automation Oct 9, 2020
@jacobperron jacobperron moved this from Proposed to Needs backport in Foxy Patch Release 4 Oct 9, 2020
@jacobperron jacobperron removed this from Needs backport in Foxy Patch Release 4 Nov 10, 2020
jacobperron pushed a commit that referenced this pull request Nov 10, 2020
@dirk-thomas @jacobperron
refactor regex for valid package/field names (#508)
1696e56 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@jacobperron jacobperron mentioned this pull request Nov 10, 2020
Closed
jacobperron pushed a commit that referenced this pull request Nov 10, 2020
@dirk-thomas @jacobperron
refactor regex for valid package/field names (#508)
02bb215 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@jacobperron jacobperron mentioned this pull request Nov 10, 2020
Merged
@jacobperron jacobperron removed this from Needs Backport in Eloquent Patch Release 2 Nov 10, 2020
@jacobperron jacobperron removed this from Needs Backport in Dashing Patch Release 8 Nov 10, 2020
nuclearsandwich pushed a commit that referenced this pull request Nov 24, 2020
@jacobperron @dirk-thomas
[dashing] refactor regex for valid package/field names (#508) (#549)
6a790fc 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
bug Something isn't working
Projects
No open projects
Rolling Ridley
Needs release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dirk-thomas @jacobperron