Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rosidl_adapter] Ignore multiple # characters and dedent comments #594

Merged
merged 3 commits into from
May 12, 2021

Conversation

ivanpauno
Copy link
Member

Extracted from #593, as I want to narrow the scope of that PR.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the enhancement New feature or request label May 12, 2021
@ivanpauno ivanpauno self-assigned this May 12, 2021
@ivanpauno
Copy link
Member Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno
Copy link
Member Author

Windows CI hasn't been working today.
I'm confident this change is platflorm independent, so I'm going to go ahead and get this one in.

@ivanpauno ivanpauno merged commit 2868145 into master May 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/rosidl-adapter-improve-comment-processing branch May 12, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants