Relocate to_yaml() under message namespace. #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables argument dependent lookups. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
Full CI, to be safe:
|
ivanpauno
approved these changes
Aug 4, 2021
| @@ -84,14 +87,14 @@ inline void to_yaml( | |||
| @[ if isinstance(member.type, BasicType)]@ | |||
| out << "@(member.name): "; | |||
| @[ if member.type.typename in ('octet', 'char', 'wchar')]@ | |||
| character_value_to_yaml(msg.@(member.name), out); | |||
| rosidl_generator_traits::character_value_to_yaml(msg.@(member.name), out); | |||
There was a problem hiding this comment.
I'm not sure if we should keep character_value_to_yaml() in rosidl_generator_traits or if we should move it to another place
There was a problem hiding this comment.
So, they have to be in a common place. I don't mind where. I figured keeping them where they are was the path of least resistance, but I'm open to ideas.
There was a problem hiding this comment.
sounds good.
rosidl_generator_traits doesn't sound like the namespace for this helper functions, but it doesn't really matter.
ivanpauno
reviewed
Aug 4, 2021
ivanpauno
approved these changes
Aug 4, 2021
sloretz
approved these changes
Aug 4, 2021
|
Alright, going in! |
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #607. This enables argument dependent lookup.
to_yaml()overloads under therosidl_generator_traitsnamespace were kept but deprecated.CI up to
rosidl_generator_cpp(to start with):