Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up the documentation for rosidl_typesupport_introspection_cpp #627

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

clalancette
Copy link
Contributor

With these changes (and one in rosbag2_cpp), this package now
builds without warnings.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

Note that this requires ros2/rosbag2#903 to go in first.

With these changes (and one in rosbag2_cpp), this package now
builds without warnings.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI and a release note for the API breakage.

@clalancette
Copy link
Contributor Author

All right, ros2/rosbag2#903 is now in. I'll run full CI on this to make sure everything is happy:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor Author

macOS failures look unrelated. Everything else is green, so going ahead and merging this, thanks for the review.

@clalancette clalancette merged commit 05ef0b5 into master Nov 5, 2021
@clalancette clalancette deleted the clalancette/fix-introspection-cpp-docs branch November 5, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants