Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rosidl_adapter, rosidl_parser] Pass comments in ros interface constants to the .idl generated files #630

Merged
merged 2 commits into from
Nov 16, 2021
Merged

[rosidl_adapter, rosidl_parser] Pass comments in ros interface constants to the .idl generated files #630

merged 2 commits into from
Nov 16, 2021

Conversation

ivanpauno
Copy link
Member

  • [rosidl_adapter] Pass comments in ros interface constants to the .idl generated files
  • [rosidl_paraser] Support comments in constant expressions according to the idl standard.

Extracted from #593.

@ivanpauno
* [rosidl_adapter] Pass comments through for constants declarations.
7cac353 
* [rosidl_paraser] Parse annotations for constants declarations.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Simplify parsing code
6d9a9f0 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the enhancement New feature or request label Nov 12, 2021
@ivanpauno ivanpauno self-assigned this Nov 12, 2021
jacobperron
jacobperron approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@ivanpauno
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno
Copy link
Member Author

Failures are unrelated, going in!

@ivanpauno ivanpauno closed this Nov 16, 2021
@ivanpauno ivanpauno reopened this Nov 16, 2021
@ivanpauno ivanpauno merged commit 0ac4130 into master Nov 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/idl-constant-declarations-comments branch November 16, 2021 17:16
@ivanpauno ivanpauno mentioned this pull request Jan 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

@hidmic hidmic Awaiting requested review from hidmic

Assignees

@ivanpauno ivanpauno

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivanpauno @jacobperron