rename nested loop index #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ibnHatab After looking at this for a bit, I think we actually don't even need the iterator in the outer loop. We never use it. So I opened up ibnHatab#1 , which just removes the iterator in the outer loop completely. If you agree with that, please merge it in (which will update this PR). Also, if there is a specific example problem that you ran into for this, it would be great if you could write a short test that shows the problem. |
clalancette
approved these changes
Jan 20, 2022
|
CI:
|
Signed-off-by: ibnHatab <lib.aca55a@gmail.com>
|
Rebased, so here is another CI:
|
|
The test failures on Windows are known. Thanks for the contribution @ibnHatab ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing minor issue with loop index mentioned in:
#642
rosidl_adapter pytest passed and no changes in IDL output visible.