Add introspection typesupport tests for C/C++ services #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hidmic
force-pushed
the
hidmic/service_introspection_tests
branch
from
0eb2b67
to
feb5ff9
Compare
hidmic
changed the base branch from
hidmic/rosidl_typesupport_introspection_tests
to
master
|
CI up to
|
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
force-pushed
the
hidmic/service_introspection_tests
branch
from
feb5ff9
to
5d3afac
Compare
j-rivero
approved these changes
Jan 28, 2022
| DEFINE_CXX_API_FOR_C_SERVICE(rosidl_typesupport_introspection_tests, srv, Arrays) | ||
| DEFINE_CXX_API_FOR_C_SERVICE(rosidl_typesupport_introspection_tests, srv, BasicTypes) | ||
| DEFINE_CXX_API_FOR_C_SERVICE(rosidl_typesupport_introspection_tests, srv, Empty) | ||
|
|
There was a problem hiding this comment.
Out of curiosity, what is the reason not to include the same types in srv than the ones used in msg? Only Arrays, BasicTypes and Empty.
There was a problem hiding this comment.
@j-rivero only these exist. See https://github.com/ros2/test_interface_files/tree/master/srv.
We're covered by message tests though, you can already see tests are quite similar once you get to service request/response messages.
delete-merged-branch
bot
deleted the
hidmic/service_introspection_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precisely what the title says, adding to #651
, to be rebased and merged after it.