Move rosidl_typesupport_introspection_c quality declaration to Q1 #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
j-rivero
force-pushed
the
q1_instrospection_c
branch
from
e7ba37f
to
9875522
Compare
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
@j-rivero PTAL. I took the liberty to improve all testing related sections. |
Thanks, it is great. |
clalancette
approved these changes
Feb 2, 2022
|
Cool! Now we need one for |
I go for it. |
This was referenced Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest changes in the repository, we are pushing the quality level in
rosidl_typesupport_introspection_cto Q1.@hidmic I left the justification of the lack performance testing in this repo to you :)