Install headers to include/${PROJECT_NAME} #658
Conversation
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
|
CI (build:
|
| @@ -41,7 +44,7 @@ if(BUILD_TESTING) | |||
|
|
|||
| ament_add_gtest(test_bounded_vector test/test_bounded_vector.cpp) | |||
| if(TARGET test_bounded_vector) | |||
| target_include_directories(test_bounded_vector PUBLIC include) | |||
| target_link_libraries(test_bounded_vector ${PROJECT_NAME}) | |||
There was a problem hiding this comment.
Not that I find this incorrect but caught my attention. The test did not link to the library before? Did it work?
There was a problem hiding this comment.
The library in this project is an INTERFACE library. It's a header only library that exports the include directory via ... INTERFACE "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>". It seemed fitting to get the include directory from that target just as targets in downstream packages would do when they depend on it. That may make a difference if in the future it also passes on compile options or definitions in addition to the include directories.
delete-merged-branch
bot
deleted the
sloretz__rosidl__include_projectname
branch
Part of ros2/ros2#1150 - this installs resource_retriever's header files to a unique directory in a merged workspace.
This only installs headers from rosidl projects to unique directories. I did not yet tackle making the headers generated by these packages install to a unique directory.