String tests #179

mikaelarguedas · 2016-12-04T09:04:20Z

This PR adds:

[rosidl_generator_py]
- length enforcement for bounded string in array in Python and the relevant unit tests
[rosidl_generator_cpp]
- a function to generate random string arrays/vector/boundedvector in c++
- msg files and tests for all String/StringArray types
- tests for PrimitivesStaticArrays that were not tested before
- a disabled test for testing bounded string assignment (we currently don't have any way to restrict std::string length)
[rosidl_generator_c]
- a TODO to remind us to test bounded strings once length restriction is enforced

dirk-thomas · 2016-12-06T15:39:11Z

rosidl_generator_cpp/test/test_array_generator.hpp

+{
+  std::default_random_engine rand_generator;
+  std::uniform_int_distribution<int> randnum(min, max);
+  std::uniform_int_distribution<int> randlen(minlength, maxlength);


I would recommend not to use random numbers for any tests. The problem is that the test will be flaky of the result depends on the values. Instead use a "known" pattern, e.g. increment numbers, or ascii characters.

Ok, I'll ticket it and change it to use known patterns in a follow-up to keep the scope of this PR narrowed to string testing

ticketed here #181

+1 for not using fuzz values. I'm ok with doing it in a follow up if that's what you want.

wjwwood

lgtm

wjwwood · 2016-12-07T23:25:57Z

rosidl_generator_cpp/test/test_array_generator.hpp

+{
+  std::default_random_engine rand_generator;
+  std::uniform_int_distribution<int> randnum(min, max);
+  std::uniform_int_distribution<int> randlen(minlength, maxlength);


+1 for not using fuzz values. I'm ok with doing it in a follow up if that's what you want.

mikaelarguedas · 2016-12-08T02:37:26Z

Yeah I'll open a follow-up not to add noise to thise one.
Thanks for reviewing

mikaelarguedas added 5 commits December 3, 2016 23:23

add support and test for arrayx of bounded strings

4afb59a

fix typo

fe3b510

add String array random generator

cb92969

add test for static arrays and various strings

1f9cd4b

add TODO to reeneable bounded string testing

5ceefe6

mikaelarguedas added the in review Waiting for review (Kanban column) label Dec 4, 2016

mikaelarguedas self-assigned this Dec 4, 2016

Windows no VLA

aa60f68

dirk-thomas reviewed Dec 6, 2016

View reviewed changes

mikaelarguedas mentioned this pull request Dec 6, 2016

[rosidl_generator_cpp] Use known patterns instead of random ones for reproducability #181

Closed

wjwwood approved these changes Dec 7, 2016

View reviewed changes

mikaelarguedas merged commit ed21607 into master Dec 8, 2016

mikaelarguedas deleted the string_tests branch December 8, 2016 02:37

mikaelarguedas removed the in review Waiting for review (Kanban column) label Dec 8, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

String tests #179

String tests #179

mikaelarguedas commented Dec 4, 2016

dirk-thomas Dec 6, 2016

mikaelarguedas Dec 6, 2016

mikaelarguedas Dec 6, 2016

wjwwood Dec 7, 2016

wjwwood left a comment

wjwwood Dec 7, 2016

mikaelarguedas commented Dec 8, 2016

String tests #179

String tests #179

Conversation

mikaelarguedas commented Dec 4, 2016

dirk-thomas Dec 6, 2016

Choose a reason for hiding this comment

mikaelarguedas Dec 6, 2016

Choose a reason for hiding this comment

mikaelarguedas Dec 6, 2016

Choose a reason for hiding this comment

wjwwood Dec 7, 2016

Choose a reason for hiding this comment

wjwwood left a comment

Choose a reason for hiding this comment

wjwwood Dec 7, 2016

Choose a reason for hiding this comment

mikaelarguedas commented Dec 8, 2016