Add emplace_back, move_assignment to BoundedVector #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Ho <christopherj.ho@gmail.com>
allenh1
reviewed
Jun 6, 2019
rosidl_generator_cpp/include/rosidl_generator_cpp/bounded_vector.hpp
Outdated
Show resolved
Hide resolved
ivanpauno
reviewed
Jun 6, 2019
There was a problem hiding this comment.
Could you add usage of the added methods in the test https://github.com/ros2/rosidl/blob/master/rosidl_generator_cpp/test/test_bounded_vector.cpp?
rosidl_generator_cpp/include/rosidl_generator_cpp/bounded_vector.hpp
Outdated
Show resolved
Hide resolved
Done. Thanks for the reminder--I got lazy. |
|
CI (fastrtps, up to rosidl_generator_cpp):
|
- Use `auto` for portability - Add unit tests - Add documentation Signed-off-by: Christopher Ho <christopher.ho@apex.ai>
wjwwood
approved these changes
Jun 7, 2019
|
Sanity check (fastrtps, up to rosidl_generator_cpp):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #384