Temporarily add extra dependencies to workaround linking issue on OS X #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
added
in review
|
does this require that connext be installed on any OS X machine, or does this just overlink harmlessly in case rmw_connext isn't being built? |
|
If you happen to not have dependencies which are specified in the manifest they are simply being ignored. |
|
+1 |
gerkey
added a commit
that referenced
this pull request
Dec 18, 2015
Temporarily add extra dependencies to workaround linking issue on OS X
|
Opened #59 to track removing this hack again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a more complete solution, but for now we'll have to workaround linking issues in tests on OS X with these changes.
See: ros2/ros2#174