Generate service header including request and response message #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to make some modifications so that services work with introspection C. |
|
huh, still not working, I think I need to change generator target dependencies |
jacquelinekay
force-pushed
the
c_services
branch
2 times, most recently
from
daacc06
to
9bdd75f
Compare
|
Should work now |
jacquelinekay
force-pushed
the
c_services
branch
2 times, most recently
from
624995c
to
7998697
Compare
| "${_output_path}/srv/rosidl_generator_c__visibility_control.h") | ||
| configure_file( | ||
| "${rosidl_generator_c_TEMPLATE_DIR}/rosidl_generator_c__visibility_control.h.in" | ||
| "${_srv_visibility_control_file}" |
There was a problem hiding this comment.
Services don't need a separate visibility control file.
|
@dirk-thomas This is ready for re-review. This is a recent CI job (the lint errors were fixed in a subsequent commit): http://ci.ros2.org/job/ci_windows/1171/ |
| @@ -107,14 +109,15 @@ add_custom_command( | |||
| ) | |||
|
|
|||
| # generate header to switch between export and import for a specific package | |||
| set(_visibility_control_file | |||
| set(_msg_visibility_control_file | |||
|
I've addressed all new comments so far. |
|
LGTM. Does any code use this? Aka does it make sense to trigger CI? |
|
There is code in the pending rcl pull request with the same branch name that uses this. |
jacquelinekay
force-pushed
the
c_services
branch
from
002aca2
to
e1d32f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rcl#27
Bit of a bikeshed question, should srv.h be a pass-through header that only includes files, and should there additionally be a srv__type_support header with the ROSIDL_GET_TYPESUPPORT_FUNCTION definition?