-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unroll group dependencies #20
Unroll group dependencies #20
Conversation
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me with green CI. @nuclearsandwich @wjwwood does this match what you expect to see?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm conflicted about whether I think it makes sense to "unroll" groups into fine-grained dependencies or use the global depend
key to maintain the same behavior between situations where groups are used and others.
I'm coming down currently on the side of making all unrolled dependencies plain depend
s so that if group support became possible in tools like rosdep and bloom it would not change dependency semantics between the group dependency and unrolled group dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm, as @nuclearsandwich said we might want to use <depend>
for consistency with the behavior of the group tag, but as we're currently not doing that with what we've already unrolled I wouldn't block this on that.
All right, CI is happy. I'm going to merge this, open an issue to follow-up with @nuclearsandwich 's concerns for a follow-up, then do a release of this package onto the buildfarm to see whether this fixes the issue. |
Intended to work around ros2/ros2#1252