Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unroll group dependencies #20

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Mar 31, 2022

Intended to work around ros2/ros2#1252

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz added the bug Something isn't working label Mar 31, 2022
@sloretz sloretz self-assigned this Mar 31, 2022
@sloretz
Copy link
Contributor Author

sloretz commented Mar 31, 2022

CI (build: all test: --packages-select rosidl_default_generators rosidl_default_runtime test_msgs sensor_msgs)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me with green CI. @nuclearsandwich @wjwwood does this match what you expect to see?

Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm conflicted about whether I think it makes sense to "unroll" groups into fine-grained dependencies or use the global depend key to maintain the same behavior between situations where groups are used and others.

I'm coming down currently on the side of making all unrolled dependencies plain depends so that if group support became possible in tools like rosdep and bloom it would not change dependency semantics between the group dependency and unrolled group dependency.

Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm, as @nuclearsandwich said we might want to use <depend> for consistency with the behavior of the group tag, but as we're currently not doing that with what we've already unrolled I wouldn't block this on that.

@clalancette
Copy link
Contributor

All right, CI is happy. I'm going to merge this, open an issue to follow-up with @nuclearsandwich 's concerns for a follow-up, then do a release of this package onto the buildfarm to see whether this fixes the issue.

@clalancette clalancette merged commit c244c3a into master Mar 31, 2022
@clalancette clalancette deleted the sloretz__rosidl_defaults__unroll_group_depend branch March 31, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants