Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uchar.h / char16_t detection/handling (fix #8) #10

Merged
merged 1 commit into from
Aug 29, 2023

Commits on Aug 29, 2023

  1. uchar: fix conditional include/typedef

    Fix incorrect check: if `__has_include(..)` was supported, but `uchar.h` did not exist, `char16_t` never got `typedef`ed.
    
    It needs to be `typedef`ed in (at least) two cases:
    
    1. `uchar.h` does not exist, and
    2. `__has_include(..)` is not supported
    
    In case of the former, the type is most likely missing. In case of the latter, `uchar.h` could exist, but existence can't be checked.
    
    Note: checking for `__has_include(..)` support and use of the macro in a combined conditional is non-portable according to the documentation, hence the split.
    gavanderhoorn committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    9c8cbba View commit details
    Browse the repository at this point in the history