Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use modern cmake targets to avoid absolute paths to appear inbinary archives (#160)" #166

Merged
merged 1 commit into from
May 17, 2022
Merged

Revert "Use modern cmake targets to avoid absolute paths to appear inbinary archives (#160)" #166

merged 1 commit into from
May 17, 2022

Conversation

ivanpauno
Copy link
Member

Revert #160 until I can get #164 right.

@ivanpauno
Revert "Use modern cmake targets to avoid absolute paths to appear in…
6ad9454 
… binary archives (#160)"

This reverts commit a608556.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the bug Something isn't working label May 16, 2022
@ivanpauno ivanpauno self-assigned this May 16, 2022
@ivanpauno ivanpauno marked this pull request as ready for review May 16, 2022 21:37
@ivanpauno
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

sloretz
sloretz approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

clalancette
clalancette approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also run RHEL and Windows Debug CI to validate that those are fixed?

@ivanpauno
Copy link
Member Author

ivanpauno commented May 17, 2022 •
edited
Loading

  • rhel Build Status
  • Windows debug Build Status

@ivanpauno ivanpauno merged commit 6675823 into master May 17, 2022
@clalancette clalancette deleted the ivanpauno/revert-#160 branch May 17, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@sloretz sloretz sloretz approved these changes

@Blast545 Blast545 Blast545 approved these changes

Assignees

@ivanpauno ivanpauno

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ivanpauno @clalancette @sloretz @Blast545