-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialization No Longer Allows float("inf") for float32 Type #169
Comments
This is also a problem for |
@sloretz sounds good. Can we make sure that PR gets a backport to humble release? |
@sloretz do you think this will be backported to humble? Looks like there was a windows compatibility issue, as well, so just want to make sure that this fix finds its way to humble. |
Hi, will this fix be backported to Humble? |
Yes, it's already done via #188 , and will be in the next patch release (later this month). |
In galactic release, we were able to use the numeric-limit value of float("inf") for a float32 type. When #128 was introduced (and subsequently we began experimenting with humble release), we observed that the numeric limit checks prevented this use case. This is creating inconsistencies as our c++ code is still able to serialize using
std::numeric_limits<T>::infinity
but the python code is not able to do so.Bug report
Required Info:
Steps to reproduce issue
Expected behavior
Set my_msg.info to INF (formerly would serialize to 3.402823e+40 in galactic)
Actual behavior
The text was updated successfully, but these errors were encountered: