add xmllint linter test #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
mikaelarguedas
added
in review
|
Thanks for the improvement. We will likely wait with running CI until after today's API freeze. |
|
Thanks for the patch. |
…ifest doesn't use format 3 features Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
|
Double check after touching the manifest: |
jacobperron
pushed a commit
to ros2/rosidl_runtime_py
that referenced
this pull request
Sep 19, 2019
* add ament_xmllint test Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> * fix xmllint error Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> * instead of leveling the schema up level the format down since the manifest doesn't use format 3 features Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this as my editors' linter was reporting the failure but all the tests were passing