Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix set_message_fields for numpy array #81

Merged
merged 1 commit into from
Aug 26, 2019
Merged

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented Aug 23, 2019

Fixes ros2/ros2cli#316.

  • Linux Build Status

@dirk-thomas dirk-thomas added bug Something isn't working in review Waiting for review (Kanban column) labels Aug 23, 2019
@dirk-thomas dirk-thomas self-assigned this Aug 23, 2019
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It would be nice to add a test for this case.

@dirk-thomas dirk-thomas merged commit 00761e5 into master Aug 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/fix316 branch August 26, 2019 17:31
@dirk-thomas dirk-thomas added this to Proposed in Dashing Patch Release 3 via automation Sep 4, 2019
dirk-thomas added a commit that referenced this pull request Sep 5, 2019
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas removed this from Proposed in Dashing Patch Release 3 Sep 5, 2019
dirk-thomas added a commit that referenced this pull request Sep 5, 2019
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
jacobperron pushed a commit to ros2/rosidl_runtime_py that referenced this pull request Sep 19, 2019
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ROS2][topic][pub] it does NOT support the size of array which is larger then 32
2 participants