Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests #89

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Refactor tests #89

merged 2 commits into from
Oct 4, 2019

Conversation

jacobperron
Copy link
Member

@jacobperron jacobperron commented Oct 4, 2019

Resolves ros2/rcl_interfaces#58

Use test_interface_files for more systematic test coverage.
Continue to use StringArrays.msg from this package for cases not covered by test_interface_files.

Use test_interface_files for more systematic test coverage.
Continue to use StringArrays.msg from this package for cases not covered by test_interface_files.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

Up to rosidl_generator_py:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobperron jacobperron merged commit b93c7bf into master Oct 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/use_test_interface_files branch October 4, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extract message / service / action files from test_msgs package
2 participants